fix: mkdirall must create the dirs for a path, not its parent

cli/config/config.go

@@ -98,7 +98,8 @@ func GetComposeFile(isStack bool, composeName string) (string, error) {
 		return "", err
 	}
 
-	io.MkdirAll(composeFilePath)
+	// create parent directory for the compose file
+	io.MkdirAll(filepath.Dir(composeFilePath))
 
 	err = io.WriteFile(composeBytes, composeFilePath)
 	if err != nil {

cli/internal/io.go

@@ -130,17 +130,15 @@ func Exists(path string) (bool, error) {
 	return true, err
 }
 
-// MkdirAll creates all directories in a path
-func MkdirAll(file string) error {
-	// check if parent dir for the file exist, otherwise create it
-	parent := filepath.Dir(file)
-	if _, err := os.Stat(parent); os.IsNotExist(err) {
-		err = os.MkdirAll(parent, 0755)
+// MkdirAll creates all directories for a directory path
+func MkdirAll(path string) error {
+	if _, err := os.Stat(path); os.IsNotExist(err) {
+		err = os.MkdirAll(path, 0755)
 		if err != nil {
 			log.WithFields(log.Fields{
 				"error": err,
-				"path":  parent,
-			}).Fatal("File cannot be created")
+				"path":  path,
+			}).Fatal("Directory cannot be created")
 
 			return err
 		}

cli/internal/io_test.go

@@ -0,0 +1,23 @@
+package internal
+
+import (
+	"path"
+	"testing"
+
+	"github.com/Flaque/filet"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestMkdirAll(t *testing.T) {
+	defer filet.CleanUp(t)
+
+	tmpDir := filet.TmpDir(t, "")
+
+	dir := path.Join(tmpDir, ".op", "compose", "services")
+
+	err := MkdirAll(dir)
+	assert.Nil(t, err)
+
+	e, _ := Exists(dir)
+	assert.True(t, e)
+}

cli/internal/state_test.go

@@ -26,10 +26,14 @@ func TestRecover(t *testing.T) {
 		"foo": "bar",
 	}
 
+	MkdirAll(workspace)
+
+	Update(ID, workspace, composeFiles, initialEnv)
+
 	runFile := filepath.Join(workspace, ID+".run")
-	MkdirAll(runFile)
+	e, _ := Exists(runFile)
+	assert.True(t, e)
 
-	Update(ID, workspace, composeFiles, initialEnv)
 	env := Recover(ID, workspace)
 
 	value, e := env["foo"]