-
Notifications
You must be signed in to change notification settings - Fork 42
chore: update GCP bucket calculation #306
chore: update GCP bucket calculation #306
Conversation
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES!
Errors seem to be the same as in upstream:
I suggest merging |
The failing tests are always the same:
|
* fix: normalise GCP bucket structure * chore: extract agent download logic from the helper method * chore: simplify * feat: support pagination when retrieving objects from a GCP bucket * chore: explain we reached the end of the list # Conflicts: # e2e/utils.go
<3 @mdelapenya Thanks |
* fix: normalise GCP bucket structure * chore: extract agent download logic from the helper method * chore: simplify * feat: support pagination when retrieving objects from a GCP bucket * chore: explain we reached the end of the list # Conflicts: # e2e/utils.go
What does this PR do?
As a result of elastic/beats#20903, we detected the URLs to get the snapshots needed to be updated. This PR is addressing this need, including some refactors:
/pull-requests/pr-21100/elastic-agent-8.0.0-SNAPSHOT-x86_64.rpm
).nextPageToken
attribute in the response. If this attribute is present, and we did not find the object in the current page, we continue paginating using the token as a query string parameter. This way, the backoff strategy will fail (and retry) if:If the object is present, then we return it's media-link, which is the public URL for the object in the bucket.
Why is it important?
This change will allow us to enable the execution of the test suite alongside any PR, simply setting the environment with a few values to use the CI snapshots for branches and pull requests:
Checklist
make notice
in the proper directory)Author's Checklist
How to test this PR locally
Testing old behavior
It will use the elastic-agent:8.0.0-SNAPSHOT image, and the agent binaries from the official artifactory.
Testing an already packaged branch
It will use the elastic-agent image built for the branch, and the agent binaries snapshots from the GCP bucket.
Testing an already packaged pull request
It will use the elastic-agent image built for the PR, and the agent binaries snapshots from the GCP bucket.
Related issues
Use cases
Follow-ups