This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: add artifact name to the bucket URI #598
Merged
mdelapenya
merged 1 commit into
elastic:master
from
mdelapenya:fix-bucket-name-after-7.10
Jan 15, 2021
Merged
fix: add artifact name to the bucket URI #598
mdelapenya
merged 1 commit into
elastic:master
from
mdelapenya:fix-bucket-name-after-7.10
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
approved these changes
Jan 15, 2021
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
Test | Results |
---|---|
Failed | 2 |
Passed | 98 |
Skipped | 9 |
Total | 109 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / Pre-Submit / Sanity checks / go vet – pre_commit.lint
- Name:
Initializing / Pre-Submit / Sanity checks / golangcilint – pre_commit.lint
The two failed tests are related to precommit, not the e2e |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 15, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 15, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 15, 2021
mdelapenya
added a commit
that referenced
this pull request
Jan 15, 2021
mdelapenya
added a commit
that referenced
this pull request
Jan 15, 2021
mdelapenya
added a commit
that referenced
this pull request
Jan 15, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a subdirectory inside the
snapshots
bucket for beats-ci-artifacts.Why is it important?
After 7.9, around 5 months ago 🤦♀️ there was a change in the bucket path to normalise the folder structure, using the artifact name (metricbeat, elastic-agent, filebeat, etc) as a parent directory under the snapshots main bucket dir. With this change, the artifacts will be located in the proper bucket folder.
Checklist
make notice
in the proper directory)Author's Checklist
How to test this PR locally
Related issues