Allow new diagnostics user, with fallback to elastic user. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support both the 'elastic' and 'elastic-internal-diagnostics' user secrets. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
requested review from
thbkrkr,
pebrc,
barkbay,
rhr323 and
kvalliyurnatt
pebrc
reviewed
Apr 24, 2024
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
commented
Apr 25, 2024
| @@ -33,7 +33,7 @@ func main() { | |||
| Long: "Dump ECK and Kubernetes data for support and troubleshooting purposes.", | |||
| PreRunE: preRunOperations, | |||
| Version: internal.Version(), | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| RunE: func(_ *cobra.Command, args []string) error { | |||
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
changed the title
pebrc
reviewed
Apr 25, 2024
Attempt to continue on failure. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: elastic/cloud-on-k8s#7723
Since we are now allowing disabling of the Elastic superuser, we need to provide additional options for Elasticsearch credentials to use during extracting of diagnostics. This allows:
elasticuser.