Logback Encoder: Configuration for using ThrowableHandlingConverters

[michaelmcfadyensky]

Relates to #103

This PR includes:

• ability to configure a single ThrowableHandlingConverter in the ecs logback encoder (example below)
• a fix for serialising stack traces as an array inside

  ecs-logging-java/ecs-logging-core/src/main/java/co/elastic/logging/EcsJsonSerializer.java

  Line 201 in 09c07cf

  public static void serializeException(StringBuilder builder, String exceptionClassName, String exceptionMessage, String stackTrace, boolean stackTraceAsArray) {

Example usage:

<configuration>
    <appender name="out" class="co.elastic.logging.logback.OutputStreamAppender">
        <encoder class="co.elastic.logging.logback.EcsEncoder">
            <throwableConverter class="ch.qos.logback.classic.pattern.NopThrowableInformationConverter"/>
            <serviceName>test</serviceName>
        </encoder>
    </appender>
    <root level="DEBUG">
        <appender-ref ref="out"/>
    </root>
</configuration>

[cla-checker-service]

💚 CLA has been signed

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-01-11T20:52:26.108+0000

• Duration: 8 min 11 sec

• Commit: 3290a55

Test stats 🧪

Test	Results
Failed	0
Passed	196
Skipped	0
Total	196

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[daniel-rolls-sky]

Hi, Sky have already signed the Elastic contributor-agreement. Is this enough to allow the CLA checks to be marked complete?

[felixbarny]

The CLA also has to be signed by each individual contributor. Let me know if I can assist.

[felixbarny]

LGTM. Sorry for dropping the ball.
Note that the CLA is still not signed. I can only merge this if the CLA is signed.

[eyalkoren]

@michaelmcfadyensky can you sign the CLA using your GitHub email?

[michaelmcfadyensky]

@eyalkoren we're currently waiting on getting myself added to Sky's company CLA. @Dro25 is chasing this up.

[felixbarny]

Any updates on the CLA?

[michaelmcfadyensky]

The Sky CLA has now been updated to include myself as a contributor

[eyalkoren]

The CLA also has to be signed by each individual contributor using the same GitHub email used by the PR author.
It doesn't seem to be the case still.
Sorry for insisting on this, but we must do so.

Once this is done, since this has been untouched for a long time, please make sure to merge with latest master and see that the tests pass.
Thanks!

[gtback]

cla/check

[gtback]

Hi @michaelmcfadyensky , sorry the CLA is giving you trouble. When you say that the Sky CLA has been updated, can you confirm how that was sent to us? Typically, we have updates sent to cla-questions@elastic.co, but I'm not seeing anything there. I did find the original Sky CLA which was submitted on June 24, 2020.

Also, updates to existing corporate CLAs require manual work on our side to add the new users. Once I confirm receipt of the updated CLA, I'll make sure to update our system and let you know.

[gtback]

@michaelmcfadyensky I received the CLA, added you and the rest of the Sky contributors, and now the CLA checker has approve that part of this PR.

I'll let @eyalkoren and @felixbarny take it from here.

[michaelmcfadyensky]

@gtback thanks for your help. It seems I may have jumped the gun with regards to messaging you guys about the updated CLA. I was not aware of the full process - TIL.

@eyalkoren I've pulled in the latest changes from master and have fixed the broken tests

[eyalkoren]

Thanks a lot @gtback and @michaelmcfadyensky!