Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: moved json_dumps call to internal helper #114

Merged
merged 4 commits into from
Jun 5, 2024
Merged

feat: moved json_dumps call to internal helper #114

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f42a9ed
feat: moved json_dumps call to internal helper
mj0nez May 15, 2024
8a42b43
Merge branch 'main' into feat/alllow-customization-of-json-dumps
mj0nez May 15, 2024
d46d7ec
Merge branch 'main' into feat/alllow-customization-of-json-dumps
mj0nez May 17, 2024
1c98365
Merge branch 'main' into feat/alllow-customization-of-json-dumps
mj0nez May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ecs_logging/_structlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __call__(self, _, name, event_dict):
event_dict = normalize_dict(event_dict)
event_dict.setdefault("log", {}).setdefault("level", name.lower())
event_dict = self.format_to_ecs(event_dict)
return json_dumps(event_dict)
return self._json_dumps(event_dict)

def format_to_ecs(self, event_dict):
# type: (Dict[str, Any]) -> Dict[str, Any]
Expand All @@ -57,3 +57,7 @@ def format_to_ecs(self, event_dict):

event_dict.setdefault("ecs", {}).setdefault("version", ECS_VERSION)
return event_dict

def _json_dumps(self, value):
# type: (Dict[str, Any]) -> str
return json_dumps(value=value)