Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging dicts for duplicate dotted keys #46

Merged
merged 9 commits into from
Jul 1, 2021
Merged

Fix merging dicts for duplicate dotted keys #46

merged 9 commits into from
Jul 1, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jun 29, 2021

Fixes #45

@basepi basepi mentioned this pull request Jun 29, 2021
Closed
@apmmachine
Copy link
Contributor

apmmachine commented Jun 29, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #46 updated

  • Start Time: 2021-07-01T14:58:16.403+0000

  • Duration: 7 min 23 sec

  • Commit: 54c5afc

Test stats 🧪

Test Results
Failed 0
Passed 235
Skipped 11
Total 246

Trends 🧪

Image of Build Times

Image of Tests

@basepi basepi mentioned this pull request Jun 30, 2021
Merged
@basepi basepi requested a review from sethmlarson June 30, 2021 18:22
sethmlarson
sethmlarson reviewed Jun 30, 2021
View reviewed changes
ecs_logging/_utils.py Outdated Show resolved Hide resolved
sethmlarson
sethmlarson reviewed Jun 30, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sethmlarson
sethmlarson suggested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, like this approach much better!

sethmlarson
sethmlarson reviewed Jun 30, 2021
View reviewed changes
tests/test_apm.py Outdated Show resolved Hide resolved
@basepi basepi requested a review from sethmlarson July 1, 2021 14:57
sethmlarson
sethmlarson approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@basepi basepi merged commit 850c9cb into elastic:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@beniwohli beniwohli Awaiting requested review from beniwohli

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StructlogFormatter throws TypeError with duplicated dotted keys
3 participants
@basepi @apmmachine @sethmlarson