Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expected_values from *.indicator.name field defs #2281

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Remove expected_values from *.indicator.name field defs #2281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06b1b24
remove expected_values for indicator.name fields
ebeahan Sep 27, 2023
6fe5aaa
generate artifacts
ebeahan Sep 27, 2023
6a669a4
changelog
ebeahan Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ Thanks, you're awesome :-) -->

#### Bugfixes

* Remove `expected_values` from `threat.*.indicator.name` fields. #2281

#### Added

#### Improvements
Expand Down
28 changes: 2 additions & 26 deletions docs/fields/field-details.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10526,19 +10526,7 @@ example: `2020-11-05T17:25:47.000Z`

a| The display name indicator in an UI friendly format

Expected values for this field:

* `5.2.75.227`
* `2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6`
* `https://example.com/some/path`
* `example.com`
* `373d34874d7bc89fd4cefa6272ee80bf`
* `b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7`
* `email@example.com`
* `HKLM\\SOFTWARE\\Microsoft\\Active`
* `13335`
* `00:00:5e:00:53:af`
* `8008`
URL, IP address, email address, registry key, port number, hash value, or other relevant name can serve as the display name.

type: keyword

Expand Down Expand Up @@ -11084,19 +11072,7 @@ example: `2020-11-05T17:25:47.000Z`

a| The display name indicator in an UI friendly format

Expected values for this field:

* `5.2.75.227`
* `2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6`
* `https://example.com/some/path`
* `example.com`
* `373d34874d7bc89fd4cefa6272ee80bf`
* `b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7`
* `email@example.com`
* `HKLM\\SOFTWARE\\Microsoft\\Active`
* `13335`
* `00:00:5e:00:53:af`
* `8008`
URL, IP address, email address, registry key, port number, hash value, or other relevant name can serve as the display name.

type: keyword

Expand Down
10 changes: 8 additions & 2 deletions experimental/generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10077,7 +10077,10 @@
level: extended
type: keyword
ignore_above: 1024
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
default_field: false
- name: enrichments.indicator.port
Expand Down Expand Up @@ -11681,7 +11684,10 @@
level: extended
type: keyword
ignore_above: 1024
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
default_field: false
- name: indicator.port
Expand Down
34 changes: 8 additions & 26 deletions experimental/generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16325,20 +16325,11 @@ threat.enrichments.indicator.modified_at:
type: date
threat.enrichments.indicator.name:
dashed_name: threat-enrichments-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or other
relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.enrichments.indicator.name
ignore_above: 1024
level: extended
Expand Down Expand Up @@ -19044,20 +19035,11 @@ threat.indicator.modified_at:
type: date
threat.indicator.name:
dashed_name: threat-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or other
relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.indicator.name
ignore_above: 1024
level: extended
Expand Down
34 changes: 8 additions & 26 deletions experimental/generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18992,20 +18992,11 @@ threat:
type: date
threat.enrichments.indicator.name:
dashed_name: threat-enrichments-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.enrichments.indicator.name
ignore_above: 1024
level: extended
Expand Down Expand Up @@ -21717,20 +21708,11 @@ threat:
type: date
threat.indicator.name:
dashed_name: threat-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.indicator.name
ignore_above: 1024
level: extended
Expand Down
10 changes: 8 additions & 2 deletions generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10027,7 +10027,10 @@
level: extended
type: keyword
ignore_above: 1024
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
default_field: false
- name: enrichments.indicator.port
Expand Down Expand Up @@ -11631,7 +11634,10 @@
level: extended
type: keyword
ignore_above: 1024
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
default_field: false
- name: indicator.port
Expand Down
34 changes: 8 additions & 26 deletions generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16256,20 +16256,11 @@ threat.enrichments.indicator.modified_at:
type: date
threat.enrichments.indicator.name:
dashed_name: threat-enrichments-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or other
relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.enrichments.indicator.name
ignore_above: 1024
level: extended
Expand Down Expand Up @@ -18975,20 +18966,11 @@ threat.indicator.modified_at:
type: date
threat.indicator.name:
dashed_name: threat-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or other
relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.indicator.name
ignore_above: 1024
level: extended
Expand Down
34 changes: 8 additions & 26 deletions generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18912,20 +18912,11 @@ threat:
type: date
threat.enrichments.indicator.name:
dashed_name: threat-enrichments-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.enrichments.indicator.name
ignore_above: 1024
level: extended
Expand Down Expand Up @@ -21637,20 +21628,11 @@ threat:
type: date
threat.indicator.name:
dashed_name: threat-indicator-name
description: The display name indicator in an UI friendly format
description: 'The display name indicator in an UI friendly format

URL, IP address, email address, registry key, port number, hash value, or
other relevant name can serve as the display name.'
example: 5.2.75.227
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008
flat_name: threat.indicator.name
ignore_above: 1024
level: extended
Expand Down
30 changes: 6 additions & 24 deletions schemas/threat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,18 +111,9 @@
short: Indicator display name
description: >
The display name indicator in an UI friendly format
expected_values:
andrewkroh marked this conversation as resolved.
Show resolved Hide resolved
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008

URL, IP address, email address, registry key, port number, hash value,
or other relevant name can serve as the display name.
example: 5.2.75.227

- name: enrichments.indicator.description
Expand Down Expand Up @@ -419,18 +410,9 @@
short: Indicator display name
description: >
The display name indicator in an UI friendly format
expected_values:
- 5.2.75.227
- 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6
- https://example.com/some/path
- example.com
- 373d34874d7bc89fd4cefa6272ee80bf
- b0e914d1bbe19433cc9df64ea1ca07fe77f7b150b511b786e46e007941a62bd7
- email@example.com
- HKLM\\SOFTWARE\\Microsoft\\Active
- 13335
- 00:00:5e:00:53:af
- 8008

URL, IP address, email address, registry key, port number, hash value,
or other relevant name can serve as the display name.
example: 5.2.75.227

- name: indicator.description
Expand Down
Loading