Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] added new field: threat.indicator.id - resolves GH-2252 #2324

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

brett-fitz
Copy link
Contributor

Note: This is a recreated PR from #2307. See comment for reason.

Added threat.indicator.id field. Resolves #2252.

The new field threat.indicator.id will allow for security systems to append a threat.indicator.id. This field can have multiple values to allow for the identification of the same indicator across systems that use different ID formats.

Common serialization format you may expect to see here is a STIX 2.x indicator id. Here is an example of one being produced.

{
            "type": "indicator",
            "spec_version": "2.1",
            "id": "indicator--8a8c60c4-00a8-43dd-ad76-8004ee718c39",
            "created": "2023-12-21T17:55:29.187214Z",
            "modified": "2023-12-21T17:55:29.187214Z",
            "name": "Malicious activity",
            "description": "Indicator for a known malicious IP address",
            "pattern": "[ipv4-addr:value = '192.168.1.1']",
            "pattern_type": "stix",
            "pattern_version": "2.1",
            "valid_from": "2023-01-01T12:00:00Z"
}

@brett-fitz brett-fitz requested a review from a team as a code owner March 27, 2024 15:58
Copy link

Documentation changes preview: https://ecs_bk_2324.docs-preview.app.elstc.co/diff

@brett-fitz
Copy link
Contributor Author

CC: @trisch-me @mjwolf

@brett-fitz brett-fitz changed the title Resolves GH-2252 [RFC] added new field: threat.indicator.id - resolves GH-2252 Mar 27, 2024
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it just needs the changelog number changed

edit: I just added that small change myself

CHANGELOG.next.md Outdated Show resolved Hide resolved
@mjwolf mjwolf requested a review from trisch-me March 28, 2024 21:47
@mjwolf mjwolf merged commit 2a06628 into elastic:main Mar 28, 2024
2 checks passed
@brett-fitz brett-fitz deleted the GH-2252 branch April 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Support id in threat.indicator for STIX 2.1
2 participants