Additions to event #439
Merged
Additions to event #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 23, 2019 15:35
This removes references of how things used to be in Beats 6 and before, and explains what .module and .dataset mean, and how to use them.
|
@ph Proposal to add |
ruflin
approved these changes
Apr 24, 2019
This was referenced Apr 24, 2019
ruflin
approved these changes
Apr 25, 2019
ph
approved these changes
Apr 29, 2019
|
Thanks guys! Waiting for Mike's input as well on this one, since it's on |
MikePaquette
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses/improves a few things in the the "event" field set.
If any of these turns out controversial / complicated, I'll be happy to extract them to a separate PR. The goal here is to get the simple things in.
event.code(See Migrate Winlogbeat to ECS, take 2 beats#10333)event.sequence(See proposal for Event fields #129, Adding Cisco support for the Syslog parser beats#10760)event.provider(See New field event.provider #321)process.namewhich is sometimes accurate, sometimes not (e.g. "kernel"). event.provider would be a better field for this.Closes #321
Addresses part of #129