Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use cases directory and code #632

Closed
wants to merge 3 commits into from

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 22, 2019

They have not been maintained for a long time. With the recent addition
of the TLS field set (#606), the information in there was outright incorrect.

@ruflin
Copy link
Contributor

ruflin commented Nov 25, 2019

I agree it needs cleanup but not sure removal is the right step here as it was a place to "share" mappings which go beyond ECS. For example the kubernetes ones. Do you have a replacement in mind?

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

Yes, there is something superior coming up soon. A description is available in the first part of this comment #601 (comment).

This will allow us and the community to share ECS mappings in a way that can also be leveraged programmatically.

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

Happy to wait until after the above project is available, if you think the use cases are still this useful.

If you think we should wait, please let me know. I'll have to fix the TLS stuff in the use cases, as it's now proposing something that's wrong.

@webmat
Copy link
Contributor Author

webmat commented Nov 25, 2019

@ruflin
Copy link
Contributor

ruflin commented Nov 26, 2019

@webmat I'm ok moving forward with removing it first before we have a replacement. Sometime I pointed users to the use cases for inspiration, but having them outdated is also not good. For the replacement: Where you expect the "example csv" to end up? In this repo?

@webmat
Copy link
Contributor Author

webmat commented Nov 29, 2019

I'm not 100% what the end result will look like. So during the experimentation phase, I will be using a separate repo. When the POC is ready, we can look at it and decide if we should move it here or not.

@webmat webmat added the 1.9.0 label Nov 10, 2020
@ebeahan ebeahan added the ready Issues we'd like to address in the future. label Nov 17, 2020
@ebeahan ebeahan removed the 1.9.0 label Feb 10, 2021
@ebeahan ebeahan added 8.0.0 and removed cleanup labels Apr 15, 2021
@ebeahan ebeahan removed 8.0.0 ready Issues we'd like to address in the future. labels May 4, 2021
@ebeahan
Copy link
Member

ebeahan commented May 4, 2021

We'll revisit this change when ready, but since this PR is quite out-of-date let's close.

New issue for tracking: #1391

@ebeahan ebeahan closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants