-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues following update to pandas 1.0.1 #141
Fix issues following update to pandas 1.0.1 #141
Conversation
* Change _stringify_path to stringify_path (make it public) * Keep the original dtype for some aggregate functions (min, max) * Fix info() formatting * Update output in notebooks cells and doctest strings
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
jenkins test this please |
@sethmlarson Thanks for triggering the build. I took a look at the log, it is failing for Python 3.5,
Currently the officially supported versions of Python for pandas 1.0.1 are 3.6.1, 3.7, 3.8. See here. Hope this helps. |
Yeah to support Pandas v1 we'd have to drop 3.5.3 which is probably fine. cc @stevedodson |
++ to mirror pandas 1.0.1 supported versions. |
Okay, let's handle that in a separate PR since it'll be a much larger change than this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change! Left your some comments.
I'll be opening a PR soon that drops Python 3.5 but also adds auto-formatting to the codebase.
This will certainly require you to do a merge commit which will probably be pretty ugly so plan for that, I can help if needed. It's also a good reason to try to keep this PR as minimal to pandas v1 as possible.
@@ -109,10 +109,10 @@ def sum(self, query_compiler, numeric_only=True): | |||
return self._metric_aggs(query_compiler, 'sum', numeric_only=numeric_only) | |||
|
|||
def max(self, query_compiler, numeric_only=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the above frames this keep_domain
change looks pretty good, would also like @stevedodson to confirm here.
@mesejo Thanks for your patience, I've merged the PR that drops support for Python 3.5 (and introduces Black code style). You'll probably have a semi-nasty merge commit to resolve but would love to get this PR up-to-date with master and then reviewed :) Thanks again! |
@sethmlarson Hi! Should I do a rebase or just a merge will suffix? |
@mesejo Merge will be fine, we'll squash the whole PR down at the end anyways! :) |
@sethmlarson Good! Just another question, should I keep the pandas version as it is? I saw a comment of yours but I cannot find it now. |
Yeah you should still change all mentions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments!
jenkins test this please |
Looks like there are some issues with whitespace:
Try running |
jenkins test this please |
Hi @sethmlarson if I remove the trailing whitespaces then the doc-test will fail, the new format of info() has two trailing whitespaces. |
@mesejo That's unfortunate! Can you add |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI passes this LGTM, thank you so much!
One question, are you okay with having your name mentioned in the release notes? We like to highlight community contributions and this one is a great example. :) |
Yes I'm okay with that :) |
Closes #124