Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No spaces in delimiters for serialized ML model #159

Merged
merged 1 commit into from
Apr 2, 2020
Merged

No spaces in delimiters for serialized ML model #159

merged 1 commit into from
Apr 2, 2020

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Apr 1, 2020 •
edited
Loading

Experimentally this makes serialized ML models from the test suite ~1% smaller. Not sure how big they can get or if this matters much but this is how clients all dump JSON.

stevedodson
stevedodson approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 38251dd into elastic:master Apr 2, 2020
@sethmlarson sethmlarson deleted the ml-smaller-serialize branch April 2, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedodson stevedodson stevedodson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethmlarson @stevedodson