-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions var, std #175
Add functions var, std #175
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective this looks good. We also need to add mad
and other aggregations too.
I'm also seeing an opportunity to refactor the .mean(), .var(), etc functions to use .aggregate() so we don't have to maintain both routes of applying these aggregations.
@sethmlarson Thanks for the comments, I agree with your perspective. Also I'm pretty positive there is a bug with median: >>> df = ed.DataFrame(es, 'flights')
>>> df[['AvgTicketPrice']].agg(['median']) throws this,
The call is made in the same way as with |
Even more reason to consolidate the implementations. :) That can be done in a separate PR though. Thanks for finding all these issues. |
I think is better to do it in a separate PR |
Okay, the v8.0.0 failures are unrelated. Merging this now! :) Thanks much! |
This add the functions var and std. It mirrors the same implementation of the other metric aggregations.
The changes were made in
_metric_aggs
, for two reasons:Closes #171