-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add median() to ndframe #176
Add median() to ndframe #176
Conversation
add median, std, and var documentation run blacken
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks great, one tiny comment!
eland/ndframe.py
Outdated
Examples | ||
-------- | ||
>>> df = ed.DataFrame('localhost', 'flights') | ||
>>> df.std() # doctest: +SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be .var()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should. Done, :)
@sethmlarson Regarding the refactoring, here are my thoughts: At least |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mesejo Would be good to keep I like the idea of build_X_query() and extract_X_response(). Would be good on the Would you be willing to create a quick mockup and submit as a PR? Doesn't need to be mergeable or tested, just something to review and think about how this might look. :) Thanks for your hard work btw, it's really appreciated. |
@sethmlarson I'm willing to do it, but I cannot guarantee that I can deliver it fast. Thank you, :) |
@mesejo No worries! Don't break your back over it, the work and design input you're doing now is already more than expected. 🎉 |
Includes: