Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xgboost v1 #200

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Add support for xgboost v1 #200

merged 1 commit into from
Apr 29, 2020

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Apr 29, 2020 •
edited
Loading

  • Adds type hints to eland/ml/_model_serializer.py
  • Added support for xgboost 1.x
  • Maintained support for xgboost 0.x (Should we test this?)
  • Added extras for eland[scikit-learn] and eland[xgboost] so users always get the right installed ML library versions.
  • Fixed a bug with single-feature calls to .predict()

Closes #133

stevedodson
stevedodson approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR and good to see more type checking going in as well!

LGTM

@sethmlarson sethmlarson force-pushed the xgboost1 branch 2 times, most recently from 85afcd8 to 853ad22 Compare April 29, 2020 17:30
@sethmlarson sethmlarson merged commit 3d81def into elastic:master Apr 29, 2020
@sethmlarson sethmlarson deleted the xgboost1 branch April 29, 2020 18:06
@sethmlarson sethmlarson mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedodson stevedodson stevedodson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to xgboost 1.0.1
2 participants
@sethmlarson @stevedodson