-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isna, notna functions #210
Add isna, notna functions #210
Conversation
add docs, blacken update pandas docs links
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @mesejo! Couple of comments for you.
jenkins test this please |
Jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the change myself in GitHub, you may have to do a git pull if you need to work on the branch again FYI
@sethmlarson What do you mean? |
@mesejo I pushed to your branch so you'll have to do a |
jenkins test this please |
I just saw it do you think is good to be merged? I saw there is a new issue for fillna and dropna. |
@mesejo Yeah I split them into separate issues because they're two different things really :) |
🎉 Thanks @mesejo! I'm planning on doing a release this week probably tomorrow. |
This commits includes:
Closes #184