Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when ingest.simulate fails without non-2XX HTTP status code #220

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Error when ingest.simulate fails without non-2XX HTTP status code #220

merged 2 commits into from
Jul 8, 2020

Conversation

sethmlarson
Copy link
Contributor

  • Adds support for submitting uncompressed ML model definitions. This helps if users want to receive errors immediately when creating a model over the compressed definition which errors out on first usage. Eland also happened to find an Elasticsearch bug by using the compressed definition so it'd be good to test both.
  • Changes ImportedMLModel.predict() to error out if an error is received within docs without a non-2XX HTTP status code.

@sethmlarson
Copy link
Contributor Author

CI is failing for an unrelated reason, going to merge this.

@sethmlarson sethmlarson merged commit de9c836 into elastic:master Jul 8, 2020
@sethmlarson sethmlarson deleted the test-ml-definitions branch July 8, 2020 19:31
@sethmlarson sethmlarson mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sethmlarson