-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MLModel(overwrite) with es_if_exists #249
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, there's a decent amount of work to do before we can merge this.
The parameter needs to have different behavior than overwrite
. The behavior should match for pandas_to_eland()
where you can pass either "fail"
to raise an error if an ML model with that ID exists (use ml.get_trained_models()
with include_model_definition=False
and if a successful response occurs then we need to raise an exception.
The other mode is replace
which calls ml.delete_trained_model
.
We also need tests for all of this behavior added in the PR.
Jenkins test this please |
Jenkins test this please |
1 similar comment
Jenkins test this please |
It looks like Mypy is failing, could you try running From Jenkins:
|
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me, thank you for fixing everything up per my review comments 😍
I'll mention you in the changelog for the upcoming release. I hope to see future contributions from you :D
In the future don't be afraid to create multiple PRs if something is still an improvement but is unrelated to the current PR, makes it easier for me to review and merge :)
Thanks @sethmlarson for the inputs and help. Will Continue to contribute 😃 |
Closes #225