-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataFrameGroupBy.count()
#292
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, this is great :) Some comments for you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything except the core functionality looks good, I'm going to pull locally and try things out to better review.
Pulled it locally and I think I found a way to work around the (It's not a |
Wait.. What ?? We could do it that simple, Without additional logic for maintaining order`. That was brilliant. 🤯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for prettying it up! :)
jenkins test this please |
Builds looking good :) |
Yeah went to grab coffee! ☕ Thank you for this PR :) |
Closes #289
Implemented
ed_df.groupby([...]).count()
ed_df.groupby([...]).agg(['count'])
ed_df.groupby([...]).agg(['max', 'min', 'count', 'mean'])
maintains ordered_df.agg['count']
hacktoberfest-accepted
label@sethmlarson Please Review :)