Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quantile to dataframe groupby #356

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Jun 11, 2021

Closes #319

Re used Most of the logic.

@sethmlarson / @stevedodson Please review

Ask jenkins to test this

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sethmlarson
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really fantastic 🎉 Two comments for you:

eland/operations.py Outdated Show resolved Hide resolved
tests/dataframe/test_groupby_pytest.py Outdated Show resolved Hide resolved
@V1NAY8 V1NAY8 requested a review from sethmlarson June 22, 2021 14:35
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment then we can merge:

eland/operations.py Outdated Show resolved Hide resolved
tests/dataframe/test_groupby_pytest.py Show resolved Hide resolved
@V1NAY8 V1NAY8 requested a review from sethmlarson June 22, 2021 15:13
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson sethmlarson merged commit 5fe32a2 into elastic:master Jun 22, 2021
@V1NAY8 V1NAY8 deleted the add-groupby-quantile branch June 22, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DataFrame.groupby().quantile()
3 participants