-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to core modules #366
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
Ask Jenkins to test this. |
jenkins test this please |
1 similar comment
jenkins test this please |
Thanks, CI is good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredible!!! 🤯 Thank you!
I've left a couple of comments and questions for you:
eland/operations.py
Outdated
@@ -947,7 +984,7 @@ def aggs_groupby( | |||
@staticmethod | |||
def bucket_generator( | |||
query_compiler: "QueryCompiler", body: "Query" | |||
) -> Generator[List[str], None, List[str]]: | |||
) -> Generator[Sequence[Any], None, Sequence[Any]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to keep this type Generator[Sequence[str], None, Sequence[str]]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[{'key': {'groupby_Cancelled': False}, 'doc_count': 11381, 'sum_dayOfWeek': {'value': 32242.0}, 'sum_FlightDelayMin': {'value': 536325.0}, 'sum_AvgTicketPrice': {'value': 7162656.040748596}}, {'key': {'groupby_Cancelled': True}, 'doc_count': 1678, 'sum_dayOfWeek': {'value': 4793.0}, 'sum_FlightDelayMin': {'value': 81825.0}, 'sum_AvgTicketPrice': {'value': 1041708.8814849854}}]
So actually its Sequence[Dict[str, Any]]
When I initially wrote it , type wasn't correct
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much!!! 🎉
Thank You so much!! :) |
No description provided.