Fallback on scroll for Elasticsearch <7.12 #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #370, basically PIT+search_after became universally safe in Elasticsearch 7.12 by adding an automatic
sort
tiebreaker field when using PITs called_shard_doc
but now we need to do feature detection to make sure we use the previous scroll method on Elasticsearch <7.12 clusters.Our new scroll method is actually better than the old one as it cleans up partially consumed scroll contexts immediately after returning instead of just allowing them to self-close over time.