-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iterrows()
and itertuples()
DataFrame API, its usage is similar to pandas
#380
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You for all these changes.
- Can you once run
pytest --doctest-modules eland/ tests/
, doctests failed in my local - Docstrings must follow https://numpydoc.readthedocs.io/en/latest/format.html
Jenkins test this please |
Ok, wait a minute, let me try. |
I run Raise a elasticsearch.exceptions.NotFoundError: no such index [flights] Maybe it’s because I don’t have the |
If you are using linux and have docker installed >>> sysctl -w vm.max_map_count=262144
>>> ELASTICSEARCH_VERSION=elasticsearch:7.x-SNAPSHOT .ci/run-elasticsearch.sh leave the above terminal open Open a different terminal and then
Then run tests |
I'd recommend only running the tests you need, some of the ML tests require a lot of resources. |
@V1NAY8 Thank you so much for the tutorial. I successfully set up a test environment. |
jenkins test this please |
Oops,It seems that the test command executed by Jenkins executes this command: Let me modify it again, I probably know the problem. |
Awesome! Thanks for all the work you've put into this, I and others really excited to use this feature! 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
jenkins test this please |
jenkins test this please |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some modifications to your test suite to make it more concise and remove the no-ops. One more round of testing and this should be good to merge! ✨
jenkins test this please |
Looks like CI is failing after removing the generator exhaustion inside of Btw you should do a |
jenkins test this please |
There was nothing wrong with the functionality, just the tests needed slightly different |
Woo! 🎉 Thank you so much for this @kxbin! I'll mention your name next to this contribution in the next release changelog. I hope you enjoyed contributing to Eland, if you've got time and are interested there are plenty of other issues to work on that I can assist with. You can also submit this contribution to the Elastic Contributor Program which recognizes community contributors and sends you prizes and swag too 🎁 |
Thank you very much for your assistance. |
I'm sorry about this, because I want to squash multiple commits, and accidentally modified the branch name.
So that the PR was automatically closed unexpectedly.
For historical Conversation see PR #369
@sethmlarson Thanks for your comment
Based on these suggestions, I have completed the modification, And passed the
lint
anddocs
jobs.Thanks to this change in #379, no need to convert
_es_results_to_pandas
into a generator now, because they have similar effects.Now, the performance has been further improved and the logic is more concise.
Finally, the same 50,000 data sets, my test results are as follows:
Closes #345