Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eland Series unique #448

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Add Eland Series unique #448

merged 3 commits into from
Mar 31, 2022

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Mar 28, 2022

Closes #446

@sethmlarson Please have a quick review :)

Happy to do any further changes required.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, the composite helpers are already paying off! Here's a handful of comments for you:

eland/operations.py Outdated Show resolved Hide resolved
eland/operations.py Outdated Show resolved Hide resolved
eland/operations.py Show resolved Hide resolved
eland/operations.py Outdated Show resolved Hide resolved
eland/series.py Outdated Show resolved Hide resolved
@V1NAY8 V1NAY8 requested a review from sethmlarson March 29, 2022 04:06
@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson
Copy link
Contributor

@V1NAY8 Looks like the test suite is failing on the string unique values, is there a way we can compare that works for all data types?

@sethmlarson
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thank you much!!

@sethmlarson sethmlarson merged commit 76a52b7 into elastic:main Mar 31, 2022
@V1NAY8 V1NAY8 deleted the add-series-unique branch March 31, 2022 13:40
@netouson
Copy link

Thank you guys, it looks amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pandas.Series.unique in eland
4 participants