Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] fixing XGBoost model import for xgboost>=1.6 #458

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[ML] fixing XGBoost model import for xgboost>=1.6 #458

merged 3 commits into from
Apr 20, 2022

Conversation

benwtrent
Copy link
Member

XGBoost >= 1.6 has removed the booster attribute from the underlying model Booster class.

This commit addresses this by adjusting the booster check to verify the the class has the attribute before checking that value.

Otherwise, we look at the top level model object booster attribute (which works fine for 1.6)

@benwtrent benwtrent added bug Something isn't working topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Apr 19, 2022
sethmlarson
sethmlarson approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 8294224 into elastic:main Apr 20, 2022
@benwtrent benwtrent deleted the feature/ml-fixing-xgboost-for-1.6 branch April 20, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwtrent @sethmlarson