-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the workaround if we can't determine the server's version #581
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
buildkite test this please |
buildkite test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to do this is it unblocks you, but note that there are other places where we look at the ES version in the same way that would break similarly.
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
Thanks! I noticed too that it was used in some other places. This one is probably in the place someone is most likely to encounter it. You get to this code by instantiating an eland DataFrame I believe. Of course I'm still trying to find out if we could grant |
|
This is related to issue #580
In some scenarios (a limited-scope API key, or maybe a corporate environment) a user of
eland
might not have enough permissions to determine the host's Elasticsearch version.In that case, we could default to using the workaround, to be sure.