Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated check_less_precise #596

Merged

Conversation

bartbroere
Copy link
Contributor

This removes the deprecated check_less_precise argument from one of the unit tests.

Part of the necessary adjustments to maybe start supporting pandas>=2.0.0

@bartbroere bartbroere changed the title Remove deprecated check less precise Remove deprecated check_less_precise Sep 11, 2023
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

@bartbroere
Copy link
Contributor Author

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Good catch! I'll update it.

@bartbroere
Copy link
Contributor Author

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Good catch! I'll update it.

@pquentin I added the check_exact=False flag, but Github still doesn't think I "addressed the requested changes". Not sure how that works, but I think it's all good now.

@pquentin
Copy link
Member

buildkite test this please

@pquentin pquentin merged commit 3908f43 into elastic:main Sep 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants