[NLP] Support E5 small multi-lingual #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/ml/pytorch/test_pytorch_model_config.py
davidkyle
added
the
topic:NLP
joshdevins
approved these changes
Oct 19, 2023
|
Does this close #583 or is another PR pending? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E5 small multi lingual is based on a BERT architecture which made the code that traces the model assume the model takes 4 parameters to its
forward()function. However, the model uses the XLMRoBERTa tokenizer which produces 2 inputs, this lead to an error when evaluating the model as it complained of missing arguments.The fix is to use the tokenizer type to determine the number of inputs to the model's
forward()functionCloses #583