-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTR feature logger #648
LTR feature logger #648
Conversation
d53fa93
to
fe2fe41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since movies.json.gz
is only used for tests, is it possible to reduce its size? with 7.43 MB
it seems to be the largest artefact in tests
.
eland/ml/ltr/ltr_model_config.py
Outdated
""" | ||
List of the feature names for the model. | ||
""" | ||
if not hasattr(self, "_feature_names"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we seem to reuse this pattern in multiple methods:
if not hasattr(self, attr_name)
# assign attribute
return attribute
this seems like a good candidate for using the cached_property
decorator: https://docs.python.org/3/library/functools.html#functools.cached_property
I see from the README that Eland supports python 3.8, 3.9, 3.10. So cached_property
should be available.
Line 57 in 926f0b9
- Supports Python 3.8, 3.9, 3.10 and Pandas 1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did change the implementation to use cached_property. Thank you for the tip.
522dd0d
to
6a94f6d
Compare
6a94f6d
to
efc8688
Compare
@@ -50,3 +50,6 @@ Permission is hereby granted, free of charge, to any person obtaining a copy of | |||
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | |||
|
|||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
|
|||
-- | |||
This product contains a adapted version of the "us-national-parks" dataset, https://data.world/kevinnayar/us-national-parks, by Kevin Nayar, https://data.world/kevinnayar, is licensed under CC BY, https://creativecommons.org/licenses/by/4.0/legalcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo - this should be "an
adapted version"
The PR provides tools for LTR query feature extraction into Eland.