Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XGBRanker #649

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Add XGBRanker #649

merged 9 commits into from
Jan 11, 2024

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Jan 5, 2024 •
edited
Loading

This PR adds XGBRanker to the list of supported model types.

@demjened demjened changed the title [WIP] Add XGBRanker and transformer Add XGBRanker and transformer Jan 11, 2024
afoucret
afoucret approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@afoucret afoucret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@demjened demjened marked this pull request as ready for review January 11, 2024 19:47
@demjened demjened merged commit 926f0b9 into elastic:main Jan 11, 2024
4 checks passed
@demjened demjened deleted the demjened/support-for-xgbranker branch January 11, 2024 20:48
@demjened demjened changed the title Add XGBRanker and transformer Add XGBRanker Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afoucret afoucret afoucret approved these changes

@davidkyle davidkyle Awaiting requested review from davidkyle

@benwtrent benwtrent Awaiting requested review from benwtrent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demjened @afoucret