Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document TLS/SSL options for import script #667

Merged
merged 4 commits into from
May 2, 2024

Conversation

pquentin
Copy link
Member

Closes #663

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps users don't realise there is online help with for the eland_import_hub_model script by running it with the --help option. Please can you add something similar to the
below reminding readers of the --help option. I think it could go in at line 64

"""
For more information about the available options run eland_import_hub_model with the --help option.

[source,bash]

$ eland_import_hub_model --help

"""

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit f7f6e0a into elastic:main May 2, 2024
6 checks passed
@pquentin pquentin deleted the tls-ssl-docs branch May 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support adding cert path to eland_import_hub_model script
2 participants