Add note about using text_similarity task for rerank to the import model CLI #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #712 several people have tried to use
--task-type rerank
to upload a reranking model to Elasticsearch where--task-type text_similarity
should be used. This change adds a message toeland_import_hub_model
help to use--task-type text_similarity
for reranking and adds the same information to the error message produced when the--task-type
argument fails validation.There isn't a straight forward extension point to change the error message produced by ArgParse when the argument as a set of valid choices. Catching and checking the
ArgumentError
is the best option I could see.Closes #712