Fix static code analysis issues (#121)

* client: checked returned error in test

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* client: skip assignment

Returned value is not used or checked.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* client: drop deprecated io/ioutil

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

---------

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

pkg/client/reader.go

@@ -9,7 +9,6 @@ import (
 	"crypto/x509"
 	"errors"
 	"io"
-	"io/ioutil"
 
 	protobuf "github.com/golang/protobuf/proto"
 	"google.golang.org/grpc"
@@ -40,7 +39,7 @@ const (
 // NewFromReader creates a new client reading the connection information from the io.Reader.
 func NewFromReader(reader io.Reader, impl StateInterface, actions ...Action) (Client, error) {
 	connInfo := &proto.StartUpInfo{}
-	data, err := ioutil.ReadAll(reader)
+	data, err := io.ReadAll(reader)
 	if err != nil {
 		return nil, err
 	}

pkg/client/store_test.go

@@ -133,7 +133,7 @@ func TestStore(t *testing.T) {
 		newTx, err := storeClient.BeginTx(ctx, false)
 		require.NoError(t, err)
 		defer newTx.Discard(ctx)
-		res, ok, err = newTx.GetKey(ctx, "test")
+		_, ok, err = newTx.GetKey(ctx, "test")
 		require.NoError(t, err)
 		require.False(t, ok)
 
@@ -142,7 +142,7 @@ func TestStore(t *testing.T) {
 		require.NoError(t, err)
 
 		// get value in one opened before commit (should still fail)
-		res, ok, err = newTx.GetKey(ctx, "test")
+		_, ok, err = newTx.GetKey(ctx, "test")
 		require.NoError(t, err)
 		require.False(t, ok)
 		newTx.Commit(ctx)

pkg/client/unit_test.go

@@ -31,6 +31,7 @@ func TestUnitUpdateWithSameMap(t *testing.T) {
 	defaultTest.config.Source = pbStruct
 
 	pbStructNew, err := structpb.NewStruct(sameMap)
+	require.NoError(t, err)
 	newUnit := &proto.UnitExpectedConfig{
 		Source: pbStructNew,
 	}