Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckinV2 message chunking doesn't account for the overhead protobuf adds for repeated structs #94

Closed
blakerouse opened this issue Jan 5, 2024 · 0 comments · Fixed by #97
Assignees
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@blakerouse
Copy link
Contributor

Currently chunk.Expected and chunk.Observed doesn't take into account that each unit has a little more overhead because of how the size is calculated go through each unit. Overhead needs to be added roughly about 4 bytes to ensure that a chunk message still doesn't end up bigger than the maximum message size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant