-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component control protocol to allow checkin to be chunked across multiple messages #3884
Fix component control protocol to allow checkin to be chunked across multiple messages #3884
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
go.mod replace will be removed once elastic/elastic-agent-client#89 is merged |
...-Fix-component-control-protocol-to-allow-checkin-to-be-chunked-across-multiple-messages.yaml
Outdated
Show resolved
Hide resolved
go.mod replace has been removed now that v7.6.0 of the elastic-agent-client has been released. |
One other thought to minimize risk when we release this, and give us an option to isolate whether chunking is causing problems: can we add a configuration option in the policy to disable chunking? Perhaps by having the agent declare that it doesn't support chunking? |
This pull request is now in conflicts. Could you fix it? 🙏
|
ac063fb
to
26cc590
Compare
I added this. |
Latest changes LGTM, will approve once we get passing tests. |
The CI failure seems unrelated (#4076) |
This pull request is now in conflicts. Could you fix it? 🙏
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What does this PR do?
Fixes component control protocol to allow checkin to be chunked across multiple messages. It is backwards compatible as well, so only clients that inform the Elastic Agent that they support chunking will chunking be used when the message is larger than that max message size.
Why is it important?
Fixes a core issue where when running large amounts of inputs in a single component that the Elastic Agent was unable to communicate the information because the amount of data being sent between the Elastic Agent and the component was larger than the max message size.
Checklist
[ ] I have made corresponding change to the default configuration files./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E test(tested in a unit test)Author's Checklist
How to test this PR locally
Related issues