Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go get usage #111

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

ycombinator
Copy link
Contributor

As explained by @fearful-symmetry in #110 (comment):

the go get operation we're using breaks on 1.22:

mage prepare:all                                                                                                                                                
go: modules disabled by GO111MODULE=off; see 'go help modules'
Error: running "go get github.com/elastic/go-licenser" failed with exit code 1

I'm guessing the original code did this since it was a bit of a hack to install binaries without using go install However, this > doesn't work in go 1.22 anymore:
https://tip.golang.org/doc/go1.22

go get is no longer supported outside of a module in the legacy GOPATH mode (that is, with GO111MODULE=off). Other build commands, such as go build and go test, will continue to work indefinitely for legacy GOPATH programs.

@ycombinator ycombinator requested a review from a team as a code owner May 24, 2024 16:45
@ycombinator ycombinator requested review from AndersonQ, pchila, fearful-symmetry and belimawr and removed request for a team, AndersonQ and pchila May 24, 2024 16:45
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 24, 2024
@fearful-symmetry fearful-symmetry merged commit ea71037 into elastic:main May 24, 2024
2 checks passed
@ycombinator ycombinator deleted the replace-go-get branch May 24, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants