Remove elastic/elastic-agent dependency #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main go.mod requires elastic/elastic-agent because it is used by v2tool. This causes users of elastic-agent-client to fetch the elastic-agent repo unnecessarily. This is doubly bad because the version of elastic-agent required does not exist; it probably came from a branch? Move v2tool to its own module to prevent this dependency leaking to users of elastic-agent-client. Update the elastic-agent module version, and adjust the v2tool code accordingly.
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
cmacknz
approved these changes
Nov 24, 2022
Merged
6 tasks
|
The root cause that this fixes for elastic-agent-client breaks the beats build. The relevant change for this repo that brings in the out-of-branch elastic-agent commit is 3e014f7. |
6 tasks
3 tasks
This was referenced Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main go.mod requires elastic/elastic-agent because it is used by v2tool. This causes users of elastic-agent-client to fetch the elastic-agent repo unnecessarily. This is doubly bad because the version of elastic-agent required does not exist; it probably came from a branch? For example, this is causing errors in APM Server's CI:
https://apm-ci.elastic.co/job/apm-server/job/apm-server-mbp/job/PR-9667/3/consoleFull
Move v2tool to its own module to prevent this dependency leaking to users of elastic-agent-client. Update the elastic-agent module version, and adjust the v2tool code accordingly.