Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kibana policy API wrappers: add IsProtected flag, add context #143

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

aleksmaus
Copy link
Member

What does this PR do?

  • Adds IsProtected to the AgentPolicy.
  • Improves Kibana policy API wrappers with added context parameter

Why is it important?

Allows to move over more custom code for E2E tests with tamper protection.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@aleksmaus aleksmaus added the enhancement New feature or request label Aug 8, 2023
@aleksmaus aleksmaus requested a review from a team as a code owner August 8, 2023 02:46
@aleksmaus aleksmaus requested review from belimawr and removed request for a team August 8, 2023 02:46
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-08T18:12:44.225+0000

  • Duration: 9 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 791
Skipped 25
Total 816

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aleksmaus aleksmaus merged commit cddd74e into elastic:main Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants