change toMapStr to public method & bug fix #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
requested review from
faec and
VihasMakwana
and removed request for
a team
khushijain21
changed the title
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
mauri870
reviewed
Oct 30, 2024
mauri870
reviewed
Oct 30, 2024
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
💚 Build Succeeded
History
|
|
I think we would not need this PR now we have #247 what do you think, @khushijain21 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes
toMapStrmethod to public from private. It also adds one more scenario toFindFoldmethodWhy is it important?
It's a prerequisite for elastic/beats#41424
Checklist
Related issues
Relates
elastic/beats#41424