Do not throw error if alterFunc does not change the original key
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
requested review from
mauri870 and
VihasMakwana
and removed request for
a team
khushijain21
added
the
Team:Elastic-Agent-Data-Plane
rdner
reviewed
Nov 4, 2024
mapstr/mapstr.go
Outdated
| return fmt.Errorf("replacement key %q already exists: %w", newKey, ErrKeyCollision) | ||
|
|
||
| // if altered key is equal to the original key, skip below delete/put func | ||
| if newKey != key { |
There was a problem hiding this comment.
I think it would be more readable if it was just:
if newKey == key {
return nil
}
Co-authored-by: Denis <denis@rdner.de>
rdner
approved these changes
Nov 4, 2024
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We do not throw error if
alterFuncdoes not change the original key. This also improves error message for when key is not foundWhy is it important?
Checklist