-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept fleet.proxy_url
policy options
#2172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
Something isn't working
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:Elastic-Agent
Label for the Agent team
skip-changelog
backport-v8.6.0
Automated backport with mergify
labels
Jan 25, 2023
michalpristas
requested review from
blakerouse and
michel-laterman
and removed request for
a team
January 25, 2023 10:11
🌐 Coverage report
|
blakerouse
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I do think we need to have unit tests to cover this method as its getting more complex.
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.6.0
Automated backport with mergify
bug
Something isn't working
skip-changelog
Team:Elastic-Agent
Label for the Agent team
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reloads proxy settings and takes these settings into account when comparing clients.
Why is it important?
When proxy settings come as part of policy they are ignored because
First one is self explanatory. second one means that even though we change proxy for a fleet server host, it is not applied because we don't look at proxy settings when comparing clients. when clients are considered equal we do not reload them and keep using old one.
Checklist
./changelog/fragments
using the changelog toolUT is difficult to add as this relies on pings of new fleet server. Suitable for new Integration test framework
Fixes: #1728