Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add 8.8.0 changelog #2720

Merged
merged 12 commits into from
May 24, 2023
Merged

docs: add 8.8.0 changelog #2720

merged 12 commits into from
May 24, 2023

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Add the 8.8.0 changelog

Why is it important?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

@AndersonQ AndersonQ added documentation Improvements or additions to documentation release labels May 22, 2023
@AndersonQ AndersonQ self-assigned this May 22, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner May 22, 2023 12:38
@AndersonQ AndersonQ requested review from michalpristas and michel-laterman and removed request for a team May 22, 2023 12:38
@elasticmachine
Copy link
Contributor

elasticmachine commented May 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-23T15:00:45.832+0000

  • Duration: 21 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 5685
Skipped 25
Total 5710

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented May 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.611% (71/72) 👍
Files 68.273% (170/249) 👍
Classes 66.951% (314/469) 👍
Methods 53.613% (957/1785) 👍
Lines 39.435% (10996/27884) 👎 -0.032
Conditionals 100.0% (0/0) 💚

Comment on lines 14 to 24
- kind: feature
summary: Adds new StateWatch GRPC for watching the current state of the running Elastic Agent
description: ""
component: ""
pr:
- https://github.com/elastic/elastic-agent/pull/2252
issue: []
timestamp: 1676571093
file:
name: 1676571093-control-state-watch.yaml
checksum: 6f7a04fdd535f0c6de37545408e1d4dc4ffde6f7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to me, this change shouldn't be communicated to our users: it's not affecting them and will be use for our own purpose.

Comment on lines 59 to 71
summary: feature-flags
description: |
Add support for feature flags, starting with one to toggle FQDN reporting in
events generated by Agent components, via the `host.name` field.
component: agent
pr:
- https://github.com/elastic/elastic-agent/pull/2218
issue:
- https://github.com/elastic/elastic-agent/issues/2185
timestamp: 1679422558
file:
name: 1679422558-feature-flags.yaml
checksum: f6a2c45b76df4b708f19d25ff569ab0394403eab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment on lines 187 to 197
- kind: feature
summary: Allow users to specify custom base paths during installation
description: ""
component: agent
pr:
- https://github.com/elastic/elastic-agent/pull/2500
issue: []
timestamp: 1681940139
file:
name: 1681940139-Allow-users-to-specify-custom-base-paths-during-installation.yaml
checksum: 7f2cf8493a3d6cf61ff9f8117b965ff2ba327046
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be officially released in 8.8.0 so we should remove it from the changelog.

Comment on lines 283 to 293
- kind: bug-fix
summary: validate the --base-path value is an absolute path
description: ""
component: ""
pr:
- https://github.com/elastic/elastic-agent/pull/2567
issue: []
timestamp: 1684747237
file:
name: 1684747237-validate---base-path-for-install-command.yaml
checksum: e8f7ba2381f133ea505e968969550ca5ebada974
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for an issue never released, we shouldn't mention it.

@pierrehilbert pierrehilbert requested a review from kilfoyle May 22, 2023 13:30
@pierrehilbert
Copy link
Contributor

pierrehilbert commented May 22, 2023

@AndersonQ I added some comments
@kilfoyle would you mind to have a look here for wording?

@AndersonQ AndersonQ changed the title Add 8.8.0 changelog docs: add 8.8.0 changelog May 22, 2023
@pierrehilbert
Copy link
Contributor

Don't forget to regenerate the asciidoc after you changed the yaml

changelog/8.8.0.yaml Outdated Show resolved Hide resolved
changelog/8.8.0.yaml Outdated Show resolved Hide resolved
changelog/8.8.0.yaml Outdated Show resolved Hide resolved
changelog/8.8.0.yaml Outdated Show resolved Hide resolved
changelog/8.8.0.yaml Outdated Show resolved Hide resolved
@kilfoyle
Copy link
Contributor

I've added a few small suggestions for the summaries in the yaml file.

@pierrehilbert I had already put together the 8.8 release notes PR so I don't think this generated Asciidoc file needs editing, as it won't be used, but let me know if I'm mistaken about that.

@pierrehilbert
Copy link
Contributor

Correct, if you already added it, we can even remove it from this PR but we should ensure that the yaml file and the asciidoc in your PR are still aligned (because we never know ;-) ).

changelog/8.8.0.yaml Outdated Show resolved Hide resolved
Comment on lines 36 to 46
- kind: feature
summary: Agent actions signature validation
description: ""
component: ""
pr:
- "2348"
issue: []
timestamp: 1678136865
file:
name: 1678136865-Agent-actions-signature-validation.yaml
checksum: 372b3c9abff7d7723e032653d46234143ac647c6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed according to Craig's comment This was disabled in https://github.com/elastic/elastic-agent/commit/ce0542fd641ea3e13d29bb2f88ea0ec403d0eed0 without removing the changelog fragment.

AndersonQ and others added 5 commits May 23, 2023 16:53
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@AndersonQ AndersonQ merged commit 33df9fc into elastic:8.8 May 24, 2023
@AndersonQ AndersonQ deleted the 8.8-release-notes branch May 24, 2023 11:11
mergify bot pushed a commit that referenced this pull request May 29, 2023
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 33df9fc)

# Conflicts:
#	changelog/fragments/1684175757-bump-node-deps.yaml
#	changelog/fragments/1685029627-Fix-deadlock-condition-in-RuntimeManager.yaml
cmacknz pushed a commit that referenced this pull request May 29, 2023
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 33df9fc)

# Conflicts:
#	changelog/fragments/1684175757-bump-node-deps.yaml
#	changelog/fragments/1685029627-Fix-deadlock-condition-in-RuntimeManager.yaml

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation forwardport-main release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants