-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch ESS region to azure-eastus2 for integ tests #3441
Conversation
This pull request does not have a backport label. Could you fix it @pchila? 🙏
NOTE: |
🌐 Coverage report
|
fc09273
to
f7ba302
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
SonarQube Quality Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -8,7 +8,7 @@ DEV=true EXTERNAL=true SNAPSHOT=true PLATFORMS=linux/amd64,linux/arm64 PACKAGES= | |||
|
|||
# Run integration tests | |||
set +e | |||
TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test | |||
TEST_INTEG_AUTH_ESS_REGION=azure-eastus2 TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add an issue to revert this change and maybe add that issue to the next sprint or something, just so we don't forget about it? Otherwise we'll keep going across data centers between the OGC-provisioned test runner hosts in GCP and ESS deployments in Azure.
And then maybe add a comment here in the code linking to that issue, again, to serve as a reminder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cherry picked from commit 69cc860)
I think we need to revert this PR and make some fixes to the ESS deployment creation code. Buildkite is failing with this error:
The |
@ycombinator I see the error on 8.10 backport but main seems fine... are we missing some commits for the integration test framework ? |
(cherry picked from commit 69cc860)
If |
What does this PR do?
Why is it important?
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself