Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ESS region to azure-eastus2 for integ tests #3441

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Sep 20, 2023

What does this PR do?

Why is it important?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify mergify bot assigned pchila Sep 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-20T15:24:27.962+0000

  • Duration: 26 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 6301
Skipped 59
Total 6360

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 66.327% (195/294) 👍
Classes 65.751% (359/546) 👍
Methods 52.76% (1128/2138) 👍
Lines 38.248% (12814/33502) 👍 0.018
Conditionals 100.0% (0/0) 💚

@pchila pchila marked this pull request as ready for review September 20, 2023 15:24
@pchila pchila requested a review from a team as a code owner September 20, 2023 15:24
@pchila pchila changed the title DO NOT MERGE - investigate stack never became ready Switch ESS region to azure-eastus2 for integ tests Sep 20, 2023
@pchila pchila added bug Something isn't working Team:Elastic-Agent Label for the Agent team skip-changelog labels Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -8,7 +8,7 @@ DEV=true EXTERNAL=true SNAPSHOT=true PLATFORMS=linux/amd64,linux/arm64 PACKAGES=

# Run integration tests
set +e
TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test
TEST_INTEG_AUTH_ESS_REGION=azure-eastus2 TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an issue to revert this change and maybe add that issue to the next sprint or something, just so we don't forget about it? Otherwise we'll keep going across data centers between the OGC-provisioned test runner hosts in GCP and ESS deployments in Azure.

And then maybe add a comment here in the code linking to that issue, again, to serve as a reminder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierrehilbert pierrehilbert merged commit 69cc860 into elastic:main Sep 20, 2023
25 of 27 checks passed
@ycombinator ycombinator added backport-v8.10.0 Automated backport with mergify and removed backport-skip labels Sep 20, 2023
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@ycombinator
Copy link
Contributor

I think we need to revert this PR and make some fixes to the ESS deployment creation code. Buildkite is failing with this error:

Error: error running test: ogc-linux-arm64-ubuntu-2204-db37 unable to continue because stack never became ready: failed to create ESS cloud for version 8.10.2-SNAPSHOT: failed to create: (cluster.invalid_deployment_template) The referenced deployment template ID [gcp-storage-optimized-v5] does not exist

The gcp-storage-optimized-v5 deployment template cannot be used in Azure. 🤦

@pchila
Copy link
Member Author

pchila commented Sep 21, 2023

@ycombinator I see the error on 8.10 backport but main seems fine... are we missing some commits for the integration test framework ?

pchila added a commit that referenced this pull request Sep 21, 2023
ycombinator pushed a commit that referenced this pull request Sep 21, 2023
(cherry picked from commit 69cc860)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
@ycombinator
Copy link
Contributor

@ycombinator I see the error on 8.10 backport but main seems fine... are we missing some commits for the integration test framework ?

If main is fine but 8.10 is broken then, yes, it looks like #3365 was missing the backport to 8.10. I see that got taken care of now and the backport for this PR here also got merged successfully. Thanks1

@pchila pchila deleted the check-stack-not-ready branch September 22, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.10.0 Automated backport with mergify bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants