Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched changelog for PR 4579 #4671

Merged

Conversation

pchila
Copy link
Member

@pchila pchila commented May 3, 2024

What does this PR do?

This PR patches changelog fragment for already merged PR #4579 specifying the savings coming from removal of beat state metricset

Why is it important?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-v8.14.0 Automated backport with mergify labels May 3, 2024
@pchila pchila self-assigned this May 3, 2024
@pchila pchila requested a review from a team as a code owner May 3, 2024 14:41
@pchila pchila requested review from michalpristas and blakerouse May 3, 2024 14:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube


# Long description; in case the summary is not enough to describe the change
# this field accommodate a description without length limits.
# NOTE: This field will be rendered only for breaking-change and known-issue kinds at the moment.
#description:
description: Removing beat state metricsets reduces the document count of indices metrics-elastic_agent.*-* by 50%, saving around 13% disk space
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4153 (comment)

Isn't the number of metrics produced dependent on the number of components running under agent? i.e. something like x document per beat per interval? so the % savings depends on the number of deployed integrations/managed beats?

We need to document which integrations we used to obtain this number and that that the savings depend on the number of inputs. More inputs = more monitoring data being written, so the total savings should be greater in terms of absolute numbers (MB) in that case.

Copy link
Member Author

@pchila pchila May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers I got are obtained using only the system integration... Those should be replicated n times for any other component that belongs in the supported component list
The % gain should stay roughly the same though if an install is running the same integrations before and after upgrading to a version that includes this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense we drop the same amount of documents from every Beat

@jlind23
Copy link
Contributor

jlind23 commented May 6, 2024

@pchila Can we merge this? :-)

@pchila pchila merged commit 7ad2f59 into elastic:main May 6, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request May 6, 2024
pierrehilbert pushed a commit that referenced this pull request May 6, 2024
(cherry picked from commit 7ad2f59)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop collecting the beat state metricset as part of agent monitoring
5 participants