Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: use GITHUB_ACTOR instead #5426

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 4, 2024

What does this PR do?

#5367 added a new feature and refactored a bit the code. Unfortuantely there was a leftover using GIT_USER, that's not anymore the case with this PR

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v requested a review from a team as a code owner September 4, 2024 17:38
@v1v v1v self-assigned this Sep 4, 2024
Copy link
Contributor

mergify bot commented Sep 4, 2024

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Sep 4, 2024
@ycombinator ycombinator requested review from blakerouse and removed request for swiatekm September 4, 2024 18:19
@v1v v1v enabled auto-merge (squash) September 4, 2024 19:53
@alexsapran
Copy link
Contributor

/test

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v merged commit f1ecf4d into elastic:main Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants