Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip x value field #88

Closed
2 tasks done
markov00 opened this issue Mar 1, 2019 · 1 comment · Fixed by #96
Closed
2 tasks done

Tooltip x value field #88

markov00 opened this issue Mar 1, 2019 · 1 comment · Fixed by #96
Assignees
@markov00
Labels
:axis Axis related issue bug Something isn't working :interactions Interactions related issue released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Mar 1, 2019

Describe the bug
The tooltip label the x value as X Value if not title on horizontal axis is available.
If multiple horizontal axis are available and only one axis title configured, the tooltip will shows X Value also if we have titles on it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Area Chart - with 4 axes storybook story (remove a title from one of the two horizontal axes)
  2. Hover over any data point

Expected behavior
Always display at least one title independently of the status of the axis titles.

We also have to include the possibility to add an hidden title on an axis so we can have the label on the tooltip but no axis title displayed on the chart

Screenshots
screenshot 2019-03-01 at 16 57 14

Version (please complete the following information):

  • OS: osx
  • Browser: chrome
  • Elastic Charts: > 2.0.0

Additional context
n/a

Errors in browser console
n/a

Kibana Cross Issues
n/a

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue :axis Axis related issue labels Mar 1, 2019
@markov00 markov00 self-assigned this Mar 11, 2019
@markov00 markov00 mentioned this issue Mar 20, 2019
Merged
21 tasks
markov00 added a commit that referenced this issue Mar 22, 2019
@markov00
feat(interactions): crosshair
5ddd1a8 
Removed any listeners from the canvas elements. Using a map for each geometry on the chart: mappings x value and any relative Y values associated. We invert the mouse coordinates using the xScale to get the right X key to use on that map. This increase the performance on highly/medium dense charts. Two new props are added to the `Settings` specs: `tooltipType` to specify the tooltip type (vertical cursor, crosshair, follow, none) and the `tooltipSnap` to snap the cursor to the grid for linear charts.

close #80, close #58, close #88
markov00 pushed a commit that referenced this issue Mar 22, 2019
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
d498484 
# [3.3.0](v3.2.0...v3.3.0) (2019-03-22)

### Features

* **interactions:** crosshair ([5ddd1a8](5ddd1a8)), closes [#80](#80) [#58](#58) [#88](#88)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 22, 2019
@markov00 markov00 added this to the 7.1 milestone Apr 1, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
8648b9d 
# [3.3.0](elastic/elastic-charts@v3.2.0...v3.3.0) (2019-03-22)

### Features

* **interactions:** crosshair ([1f0cd2e](elastic/elastic-charts@1f0cd2e)), closes [opensearch-project#80](elastic/elastic-charts#80) [opensearch-project#58](elastic/elastic-charts#58) [opensearch-project#88](elastic/elastic-charts#88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:axis Axis related issue bug Something isn't working :interactions Interactions related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(interaction): crosshair markov00/elastic-charts
1 participant
@markov00