Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stories ts check on commit and build #132

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

markov00
Copy link
Member

Summary

This PR add a ts checks also on typescript stories to avoid having a broken master.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • [ ] Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@markov00 markov00 added the bug Something isn't working label Mar 29, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@092e7f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage          ?   92.84%           
=========================================
  Files             ?       31           
  Lines             ?     1481           
  Branches          ?      163           
=========================================
  Hits              ?     1375           
  Misses            ?       92           
  Partials          ?       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092e7f4...fc5804d. Read the comment docs.

@markov00 markov00 merged commit 56b173d into elastic:master Mar 29, 2019
@markov00
Copy link
Member Author

markov00 commented Apr 1, 2019

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 1, 2019
@markov00 markov00 deleted the fix-storybook branch April 16, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants