-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(heatmap): dark mode with theme controls #1406
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
853d82f
feat(heatmap): dark mode with theme controls (#1356)
nickofthyme 38550e5
Merge branch 'master' into heatmap-theming
nickofthyme 7768e61
chore: fix types and test errors from merge
nickofthyme 73f0985
Merge branch 'master' into heatmap-theming
nickofthyme 9a9639e
fix: type errors from merge
nickofthyme 3d0c91c
chore: update vrt screenshots
nickofthyme f489377
fix: api type errors
nickofthyme 9df89d6
Merge branch 'master' into heatmap-theming
nickofthyme 41894a6
refactor(wordcloud): cleanup config, types and theming (#1407)
nickofthyme ffb20aa
fix: merge type error
nickofthyme 06240f4
chore: address comments and failing checks
nickofthyme 4cd88b4
Merge remote-tracking branch 'origin/heatmap-theming' into heatmap-th…
nickofthyme 023c563
fix: api changes
nickofthyme 879ae5d
test: fix vrt theme param interpolation
nickofthyme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+57.1 KB
...l-tests-for-all-stories-heatmap-alpha-theming-visually-looks-correct-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+42.2 KB
...ories-test-ts-heatmap-stories-theme-dark-should-render-basic-heatmap-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+43.4 KB
...-test-ts-heatmap-stories-theme-dark-should-render-correct-brush-area-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+43.2 KB
...s-test-ts-heatmap-stories-theme-eui-dark-should-render-basic-heatmap-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+44.7 KB
...t-ts-heatmap-stories-theme-eui-dark-should-render-correct-brush-area-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+40.4 KB
...-test-ts-heatmap-stories-theme-eui-light-should-render-basic-heatmap-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+41.2 KB
...-ts-heatmap-stories-theme-eui-light-should-render-correct-brush-area-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+40.4 KB
...ries-test-ts-heatmap-stories-theme-light-should-render-basic-heatmap-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+41.2 KB
...test-ts-heatmap-stories-theme-light-should-render-correct-brush-area-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 0 additions & 102 deletions
102
packages/charts/src/chart_types/heatmap/layout/config/config.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in this PR but we should find a way to express this in the right way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate what you mean here? Would #1421 solve this?