-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legend): hide legend item if hideLegendItem on series spec is true #147
feat(legend): hide legend item if hideLegendItem on series spec is true #147
Conversation
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 92.9% 92.91% +<.01%
==========================================
Files 33 33
Lines 1495 1497 +2
Branches 166 167 +1
==========================================
+ Hits 1389 1391 +2
Misses 92 92
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested locally on chrome
# [3.7.0](v3.6.0...v3.7.0) (2019-04-04) ### Features * **legend:** hide legend item if hideLegendItem on series spec is true ([#147](#147)) ([6761c2b](6761c2b))
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [3.7.0](elastic/elastic-charts@v3.6.0...v3.7.0) (2019-04-04) ### Features * **legend:** hide legend item if hideLegendItem on series spec is true ([opensearch-project#147](elastic/elastic-charts#147)) ([57c4fda](elastic/elastic-charts@57c4fda))
Summary
close #137
This PR introduces a new property to the series spec
hideInLegend
which, when true, will remove the legend item from being visible in the legend list.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.